Skip to content

fix: make paginated tables fit terminal dimensions - #1896

Open
aidandaly24 wants to merge 3 commits into
refactorfrom
fix/data-table-content-height
Open

fix: make paginated tables fit terminal dimensions#1896
aidandaly24 wants to merge 3 commits into
refactorfrom
fix/data-table-content-height

Conversation

@aidandaly24

@aidandaly24 aidandaly24 commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • render the DataTable filter prompt in the existing divider row so filtering does not change table height
  • increase the terminal-derived page size by one so full paginated tables reach the footer
  • make Runtime Version and Harness Version tables fill the available terminal width
  • left-truncate overlong filter queries so the filter remains one row while preserving the full value for matching
  • cover all production table width configurations and the paginated 60x24 layout with regressions

Testing

  • focused DataTable, pagination, width, and key-hint tests (30 pass, 0 fail)
  • CI unit tests on Linux, macOS, and Windows
  • source-scoped TypeScript check excluding ignored generated dist assets
  • bun run lint:check
  • bun run format:check
  • bun run build
  • live Runtime Version and Harness Version validation at 120x32
  • live paginated Runtime List validation at 60x24
  • live long-filter validation at 60x24

@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 3, 2026
@codecov-commenter

codecov-commenter commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.08%. Comparing base (5d00ac0) to head (00c755c).

Additional details and impacted files 
@@            Coverage Diff            @@
##           refactor    #1896   +/-   ##
=========================================
  Coverage     96.08%   96.08%           
=========================================
  Files           224      224           
  Lines         11282    11294   +12     
=========================================
+ Hits          10840    10852   +12     
  Misses          442      442

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 3, 2026
@aidandaly24 aidandaly24 changed the title fix: fill paginated tables to footer fix: make paginated tables fit terminal dimensions Aug 3, 2026
nborges-aws
nborges-aws reviewed Aug 4, 2026
View reviewed changes
Comment thread src/components/ui/data-table/DataTable.tsx
nborges-aws
nborges-aws previously approved these changes Aug 4, 2026
View reviewed changes
@aidandaly24
aidandaly24 force-pushed the fix/data-table-content-height branch from aa072c5 to 00c755c Compare August 4, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nborges-aws nborges-aws nborges-aws approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aidandaly24 @codecov-commenter @nborges-aws